Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds information_schema.schemata #3051

Merged
merged 4 commits into from
Dec 29, 2023
Merged

feat: adds information_schema.schemata #3051

merged 4 commits into from
Dec 29, 2023

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Dec 29, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

TODO:

  • refactor columns, tables, and schemata, they can use the same framework or helper functions.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2931

@killme2008 killme2008 marked this pull request as ready for review December 29, 2023 08:46
@github-actions github-actions bot added Invalid PR Title docs-not-required This change does not impact docs. labels Dec 29, 2023
@killme2008 killme2008 mentioned this pull request Dec 29, 2023
Open
37 tasks
@killme2008 killme2008 changed the title Feature/schemameta feat: adds information_schema.schemata Dec 29, 2023
@killme2008 killme2008 mentioned this pull request Dec 29, 2023
Closed
14 tasks
shuiyisong
shuiyisong approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FLTM

@github-actions github-actions bot added Size: L and removed Size: M labels Dec 29, 2023
@killme2008 killme2008 enabled auto-merge December 29, 2023 09:07
@killme2008 killme2008 added this pull request to the merge queue Dec 29, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (d22072f) 85.50% compared to head (f5d6751) 84.94%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3051      +/-   ##
==========================================
- Coverage   85.50%   84.94%   -0.56%     
==========================================
  Files         793      795       +2     
  Lines      128562   128717     +155     
==========================================
- Hits       109931   109343     -588     
- Misses      18631    19374     +743

Merged via the queue into GreptimeTeam:main with commit 11ae85b Dec 29, 2023
15 checks passed
@killme2008 killme2008 deleted the feature/schemameta branch December 29, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuiyisong shuiyisong shuiyisong approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@sunng87 sunng87 sunng87 approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@killme2008 @sunng87 @MichaelScofield @shuiyisong